fix fixture path losing suffix after dynamic ID substitution#1549
Merged
tomer-stripe merged 3 commits intostripe:masterfrom May 8, 2026
Merged
fix fixture path losing suffix after dynamic ID substitution#1549tomer-stripe merged 3 commits intostripe:masterfrom
tomer-stripe merged 3 commits intostripe:masterfrom
Conversation
tomer-stripe
approved these changes
May 8, 2026
Collaborator
|
Trying to figure out how to get github to rerun the required tests so I can squash and merge this |
2 tasks
tomer-stripe
added a commit
that referenced
this pull request
May 8, 2026
## Summary - Re-adds `pull_request` trigger to the test workflow - Fixes fork PRs being unable to satisfy required `test (1.26.0, ...)` branch protection checks The test workflow was changed to push-only in #1560, which inadvertently broke CI for all fork/external PRs. Fork pushes only fire workflows on the fork repo, so the required checks never appear on community PRs. This workflow doesn't use secrets, so it's safe to run on fork PRs. ## Test plan - [x] Verify this PR itself triggers the `test (1.26.0, ...)` checks - [ ] Verify existing fork PRs (e.g. #1549) get CI runs after merge 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1340
When using dynamic IDs in fixture paths like
/v1/customers/${customer:id}/sources/${bank_account:id}/verify, the/verifysuffix was stripped during ID resolutionThe bug was in
ParsePathinpkg/parsers/parsers.go- the condition for appending the trailing path segment after the last regex match usedlen(pathParts)%2 == 0, which only works when there is exactly one dynamic ID in the path. With two or more dynamic IDs the modulo check fails and the trailing segment is droppedChanged the condition to
len(pathParts) > len(matches), which correctly appends the trailing segment regardless of how many dynamic IDs appear in the pathAdded a test case covering two dynamic IDs with a trailing path suffix